Re: [rfc] sigstep additions

[Michael Chastain <mec dot gnu at mindspring dot com>]

Andrew Cagney <cagney@gnu.org> wrote:
> I'd like to turn this into an RFA.

The superficial parts are all good.

I'm not qualified to comment on the signal handling innards.

I'll approve it in 24-48 hours, unless Daniel or Mark has an objection
or wants more time for review.  (Not even sure if Mark has an interest
in signal handling).

I tried it in three configurations and got these non-PASS results:

  native i686-pc-linux-gnu with red hat linux 8,
  kernel 2.4.18-14-rh, glibc 2.2.93-5-rh
  gcc 3.3.4, binutils 2.15, -gdwarf-2

    FAIL: gdb.base/sigstep.exp: step breakpoint to handler; performing step
    FAIL: gdb.base/sigstep.exp: next breakpoint to handler; performing next
    FAIL: gdb.base/sigstep.exp: continue breakpoint to handler; performing continue

  native hppa2.0w-hp-hpux11.11, hp ansi c B.11.11.28706.gp

    FAIL: gdb.base/sigstep.exp: step from handler; leave handler
    FAIL: gdb.base/sigstep.exp: stepi from handleri; leave signal trampoline
    FAIL: gdb.base/sigstep.exp: next from handler; leave handler
    FAIL: gdb.base/sigstep.exp: nexti from handleri; leave signal trampoline

  native hppa2.0w-hp-hpux11.11, gcc 3.3.4

    FAIL: gdb.base/sigstep.exp: backtrace for nexti (pattern 2)
    FAIL: gdb.base/sigstep.exp: step from handler; leave handler
    FAIL: gdb.base/sigstep.exp: stepi from handleri; leave signal trampoline
    FAIL: gdb.base/sigstep.exp: next from handler; leave handler
    FAIL: gdb.base/sigstep.exp: nexti from handleri; leave signal trampoline
    FAIL: gdb.base/sigstep.exp: finish from handleri; leave handler
    FAIL: gdb.base/sigstep.exp: return from handleri; leave handler

I can send you gdb.log files if you want to work on it more.  It's okay
with me to have FAILs in the results, as long as the test script is
doing real work (as opposed to bombing out with a compiler error).

Michael C

===

2004-08-10  Andrew Cagney  <cagney@gnu.org>

	* gdb.base/sigstep.exp (breakpoint_to_handler)
	(skip_over_handler, skip_to_handler): New test procedures.
	(advance, advancei): Add a proper prefix, do not use
	rerun_to_main.
	* gdb.base/sigstep.c (main): Change to use an infinite loop.