This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] more reformatting in ada-lang.c


I must say I am really non-plussed by indent. I committed the attached
patch to fix the formatting where it was the most horrible and unreadable.
I did it in a way that indent would then keep the formatting as is, so
subsequent runs of gdb_indent.sh should not revert the current layout to
the ugly one.

There are other instances where Paul and I agree that the new formatting
is not as good as the previous one. For instance:

        @@ -9957,10 +9962,7 @@ struct type **const (ada_builtin_types[]
           &builtin_type_unsigned_long,
           &builtin_type_unsigned_long_long,
           &builtin_type_long_double,
        -  &builtin_type_complex,
        -  &builtin_type_double_complex,
        -  0
        -};
        +    &builtin_type_complex, &builtin_type_double_complex, 0};

where it decided to join the last 3 lines, or

        @@ -3974,8 +4010,7 @@ ada_make_symbol_completion_list (const c
        
               for (psym = objfile->global_psymbols.list + ps->globals_offset;
                    psym < (objfile->global_psymbols.list + ps->globals_offset
        -                + ps->n_global_syms);
        -           psym++)
        +                 + ps->n_global_syms); psym++)

I guess we'll have to live with this...

2004-06-28  Joel Brobecker  <brobecker@gnat.com>

        * ada-lang.c: Re-indent file, with some massaging to help indent
        a bit when the result is otherwise really too ugly.

-- 
Joel

Attachment: ada-lang.c.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]