This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix frame ID comparison problem on s390


On Mon, Jun 28, 2004 at 12:53:43AM +0200, Andreas Schwab wrote:
> Daniel Jacobowitz <drow@false.org> writes:
> 
> >> +   /* Flags to indicate the above fields have valid contents.  */
> >> +   int stack_addr_p : 1;
> >> +   int code_addr_p : 1;
> >> +   int special_addr_p : 1;
> >>   };
> >>   
> >>   /* Methods for constructing and comparing Frame IDs.
> >
> > Some future version of GCC will warn about this mistake.  The only
> > valid values for "int : 1" are 0 and -1.
> 
> Actually it can be both 0/-1 and 0/1, since it is implementation defined
> whether unadorned int bitfields are signed or unsigned.

Huh, thank you.  In any case, thanks for making this explicit, Ulrich.

-- 
Daniel Jacobowitz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]