This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Fix frame ID comparison problem on s390
- From: Daniel Jacobowitz <drow at false dot org>
- To: Ulrich Weigand <weigand at i1 dot informatik dot uni-erlangen dot de>
- Cc: Andrew Cagney <cagney at gnu dot org>, gdb-patches at sources dot redhat dot com
- Date: Sun, 27 Jun 2004 17:48:31 -0400
- Subject: Re: [PATCH] Fix frame ID comparison problem on s390
- References: <40D08438.8090009@gnu.org> <200406272047.WAA10464@faui1m.informatik.uni-erlangen.de>
On Sun, Jun 27, 2004 at 10:47:58PM +0200, Ulrich Weigand wrote:
> Andrew Cagney wrote:
>
> > with those changes its ok,
>
> Thanks; here's the version I finally committed.
>
> (Sorry it took so long, I got sidetracked by a kernel bug triggered
> by running the gdb test suite that caused random kernel memory
> corruption :-/)
Thanks! Just one small nit. If you're going to do this:
> + id.stack_addr_p = 1;
> id.code_addr = code_addr;
> + id.code_addr_p = 1;
> id.special_addr = special_addr;
> + id.special_addr_p = 1;
Then these should be "unsigned int : 1":
> + /* Flags to indicate the above fields have valid contents. */
> + int stack_addr_p : 1;
> + int code_addr_p : 1;
> + int special_addr_p : 1;
> };
>
> /* Methods for constructing and comparing Frame IDs.
Some future version of GCC will warn about this mistake. The only
valid values for "int : 1" are 0 and -1.
--
Daniel Jacobowitz