This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] testsuite/gdb.base/attach.exp: Fix some Cygwin problems


On Jun 25 09:34, Daniel Jacobowitz wrote:
> On Fri, Jun 25, 2004 at 03:16:49PM +0200, Corinna Vinschen wrote:
> > Hi,
> > 
> > on Cygwin, some of the attach tests are simply failing because the
> > corresponding output string isn't correctly checked for.  The below
> > patch fixes that partly.  Some of the tests will need changes in GDB
> > so I didn't care for them as part of this testsuite fix.
> > 
> > Ok to check in?
> > 
> > 
> > Corinna
> > 
> > 
> > 	* gdb.base/attach.exp: Set testpid to Windows PID for Cygwin.
> > 	(do_attach_tests): Add Cygwin specific strings to check for
> > 	in the nonsense test, the boguspid test and the attach1 test.
> 
> OK.

Thanks for the quick review.

Unfortunately I just found that this change is useless, unless some
changes in win32-nat.c are made.  I'll defer to apply this change until
I have fixed the related problem in win32-nat.c


Corinna

-- 
Corinna Vinschen
Cygwin Co-Project Leader
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]