This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: patch to fix gdb/1680
- From: Jim Blandy <jimb at redhat dot com>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: Michael Elizabeth Chastain <mec dot gnu at mindspring dot com>, gdb-patches at sources dot redhat dot com, Keith Seitz <keiths at redhat dot com>, Andrew Cagney <cagney at gnu dot org>
- Date: 18 Jun 2004 17:20:08 -0500
- Subject: Re: RFA: patch to fix gdb/1680
- References: <20040618191836.629204B104@berman.michael-chastain.com><20040618194250.GA28102@nevyn.them.org>
Daniel Jacobowitz <drow@false.org> writes:
> On Fri, Jun 18, 2004 at 03:18:36PM -0400, Michael Chastain wrote:
> > drow> Does it work if you put a backslash in front of them instead? That's
> > drow> clearer to read, IMO.
> >
> > On my machine (expect 5.41):
> >
> > "{...}" ERROR: Process no longer exists
> > "\{...\}" ERROR: Process no longer exists
> > "\\{...\\}" Works fine
>
> This error means that, somewhere, a syntax error has occured and
> dejagnu has swallowed it. I submitted a patch to DejaGNU to diagnose
> this better and it was ignored in the general confusion that is DejaGNU
> maintenance.
>
> > I definitely want Jim's patch so that i386-sse.exp does its job.
> > If you insist, we could make PR gdb/1680 suspended instead of
> > closing it, to remind us of this unsolved mystery.
>
> I prefer to solve the mystery instead.
>
> If you pull that patch out of the DejaGNU list archives and apply it,
> you will see:
> ERROR OCCURED: couldn't compile regular expression pattern: invalid repetition count(s)
>
> Presumably this version of TCL does not put special meaning on
> {string}, but does on {NUMBER}, as has become fashionable for regex
> engines. When it sees {stringStartingWithADigit}, it tries to parse it
> as a repetition count and throws an error.
Ahh. Here is a revision of my patch. It is tested under the same
configuration as the original patch.
2004-06-17 Jim Blandy <jimb@redhat.com>
Fix PR testsuite/1680.
* gdb.arch/i386-sse.exp: Don't use curly braces in regular
expressions.
Index: gdb/testsuite/gdb.arch/i386-sse.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-sse.exp,v
retrieving revision 1.1
diff -c -p -r1.1 i386-sse.exp
*** gdb/testsuite/gdb.arch/i386-sse.exp 7 Jun 2004 15:38:52 -0000 1.1
--- gdb/testsuite/gdb.arch/i386-sse.exp 18 Jun 2004 22:15:52 -0000
*************** gdb_continue_to_breakpoint "continue to
*** 71,77 ****
foreach r {0 1 2 3 4 5 6 7} {
gdb_test "print \$xmm$r.v4_float" \
! ".. = {$r, $r.25, $r.5, $r.75}.*" \
"check contents of %xmm$r"
}
--- 71,77 ----
foreach r {0 1 2 3 4 5 6 7} {
gdb_test "print \$xmm$r.v4_float" \
! ".. = \\{$r, $r.25, $r.5, $r.75\\}.*" \
"check contents of %xmm$r"
}
*************** gdb_continue_to_breakpoint "continue to
*** 86,91 ****
foreach r {0 1 2 3 4 5 6 7} {
gdb_test "print data\[$r\]" \
! ".. = {f = {[expr $r + 10], $r.25, $r.5, $r.75}}.*" \
"check contents of data\[$r\]"
}
--- 86,91 ----
foreach r {0 1 2 3 4 5 6 7} {
gdb_test "print data\[$r\]" \
! ".. = \\{f = \\{[expr $r + 10], $r.25, $r.5, $r.75\\}\\}.*" \
"check contents of data\[$r\]"
}