This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/testsuite] Extend signull to work with discriptors
- From: Andrew Cagney <cagney at gnu dot org>
- To: Michael Elizabeth Chastain <mec dot gnu at mindspring dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 16 Jun 2004 12:43:34 -0400
- Subject: Re: [rfa/testsuite] Extend signull to work with discriptors
- References: <20040616153901.0B93F4B104@berman.michael-chastain.com>
We're going to have to live with this - the testsuite needs to include
deliberately erroneous programs.
Yeah, I see what you're saying, and I agree. It's not like the test
program is gratuitously non-conforming. You need this 'desc' to do what
it's doing in order to test what you're testing.
Can you add one more comment? Something like:
/* desc is intentionally initialized to a data object.
This is needed to test descriptors on arches like ia64. */
stolen :-)
It's the old "move the mailing list discussion into a comment" request.
With a comment like this, this patch is approved. (And also maybe you
have better wording for the comment than I can think of).
committed the attached,
Andrew
2004-06-16 Andrew Cagney <cagney@gnu.org>
* gdb.base/signull.c: Update copyright. Include <string.h>.
(bowler): Replace data_pointer with data_read
and data_write cases. Add code_descriptor case.
(zero, desc): New array and pointer.
(data, code): Change to simple pointers.
* gdb.base/signull.exp: Fix probe pattern matching a function
descriptor SIGSEGV. Replace data_pointer with data_read and
data_write tests.
Index: gdb.base/signull.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/signull.c,v
retrieving revision 1.3
diff -p -u -r1.3 signull.c
--- gdb.base/signull.c 22 May 2004 13:14:22 -0000 1.3
+++ gdb.base/signull.c 16 Jun 2004 16:37:58 -0000
@@ -1,6 +1,6 @@
/* This testcase is part of GDB, the GNU debugger.
- Copyright 1996, 1999, 2003 Free Software Foundation, Inc.
+ Copyright 1996, 1999, 2003, 2004 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -20,9 +20,10 @@
#include <signal.h>
#include <setjmp.h>
#include <stdlib.h>
+#include <string.h>
enum tests {
- code_entry_point, code_descriptor, data_pointer
+ code_entry_point, code_descriptor, data_read, data_write
};
static volatile enum tests test;
@@ -31,8 +32,12 @@ static volatile enum tests test;
typedef long data_t;
typedef long code_t (void);
-static volatile data_t *data[10];
-static volatile code_t *code[10];
+data_t *volatile data;
+code_t *volatile code;
+/* "desc" is intentionally initialized to a data object. This is
+ needed to test function descriptors on arches like ia64. */
+data_t zero[10];
+code_t *volatile desc = (code_t *) (void *) zero;
sigjmp_buf env;
@@ -47,12 +52,21 @@ bowler (void)
{
switch (test)
{
- case data_pointer:
- return *data[0];
+ case data_read:
+ /* Try to read address zero. */
+ return (*data);
+ case data_write:
+ /* Try to write (the assignment) to address zero. */
+ return (*data) = 1;
case code_entry_point:
- return code[0] ();
+ /* For typical architectures, call a function at address
+ zero. */
+ return (*code) ();
case code_descriptor:
- return ((code_t *) &code) ();
+ /* For atypical architectures that use function descriptors,
+ call a function descriptor, the code field of which is zero
+ (which has the effect of jumping to address zero). */
+ return (*desc) ();
}
}
Index: gdb.base/signull.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/signull.exp,v
retrieving revision 1.1
diff -p -u -r1.1 signull.exp
--- gdb.base/signull.exp 13 May 2004 18:12:07 -0000 1.1
+++ gdb.base/signull.exp 16 Jun 2004 16:37:58 -0000
@@ -79,7 +79,7 @@ gdb_test "set test = code_entry_point" "
set test "probe function pointer"
set function_pointer code_entry_point
gdb_test_multiple "continue" "$test" {
- -re "Program received signal SIGSEGV.* bowler .$gdb_prompt $" {
+ -re "Program received signal SIGSEGV.*bowler .*$gdb_prompt $" {
set function_pointer code_descriptor
pass "$test (function descriptor)"
}
@@ -109,7 +109,10 @@ proc test_segv { name tag bt_from_segv b
gdb_test backtrace $bt_from_keeper "backtrace keeper for ${name}"
}
-test_segv data data_pointer \
+test_segv data-read data_read \
+ {#0 .* bowler .*#1 .* main .*} \
+ {#0 .* keeper .*#1 .* handler .*#2 .* bowler .*#3 .* main .*}
+test_segv data-write data_write \
{#0 .* bowler .*#1 .* main .*} \
{#0 .* keeper .*#1 .* handler .*#2 .* bowler .*#3 .* main .*}
test_segv code $function_pointer \