This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/testsuite?] Rewrite long_long.exp


This patch is approved.  Good job.

A bunch of secondary comments ...

It looks like I just hit some of the same bits that you are hitting
with copyright notices and stuff, so you have to iron out a few
conflicts.

For this bit:

  -gdb_test "n 4"   ".*38.*" "get to known place"
  +# Get to a known place
  +
  +gdb_test "n 4"   "val.hex = val.bin - val.dec . val.oct.*" "get to known place"

Just use the new code with gdb_get_line_number.  In general, test
scripts should not rely on absolute line numbers in the foo.c files.
Anything that accomplishes this goal is okay.

As far as removing PROTOTYPES goes: the purpose of PROTOTYPES is to test
pre-Ansi C compilers.  About six months ago, I actually tried a test run
with the hpux bundled compiler, which is an old pre-Ansi compiler with
no prototype support.  I found that there are already dozens of test
scripts that do not use PROTOTYPES and do not work.  So I'm gonna say,
it's okay to throw out PROTOTYPES in most foo.c files, as long as the
point of the test is not directly related to prototypes.

ac> Tested on ppc, amd64, i386 and d10v(sob).

Cool.  There might be bugs in the new code, but at least they will be
non-trivial.  :)

Michael C

===

2004-06-14  Andrew Cagney  <cagney@gnu.org>

	* gdb.base/long_long.exp, gdb.base/long_long.c: Rewrite.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]