This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rfc] Eliminate register_value_being_returned and legacy_return_value


   Date: Thu, 10 Jun 2004 17:06:42 -0400
   From: Andrew Cagney <cagney@gnu.org>

   Hello,

   This patch eliminates calls to both register_value_being_returned and 
   legacy_return_value by inlining / simplifying the callers.  Turns out 
   there was much duplication of effort with both the caller and callees 
   all performing the same tasks.

This patch gives me a bad feeling.  I had intentionally introduced
legacy_return_value to isolate all the legacy code in a single
function.  Yes, that duplicates some of the code, but I think it makes
the code much, much easier to understand.  It also makes removing the
legacy code much more easier later on.

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]