This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rfc;testsuite] Append patchlevel to compiler_info


This is good.  I think it needs a comment that gcc supports
__GNUC_PATCHLEVEL__ starting with gcc 3.0, so that we know how long
we need to keep the conditional logic.

Can you do a before-and-after test with gcc 2.95.3 and with some
version of gcc 3.X ?  I expect that all the "gcc-2-*" and "gcc-*-*"
will continue to work but that really needs testing.  They can be
improved to "gcc-2-*-*" and "gcc-*-*-*" later.

Hmmm, come to think of it, I don't know if "gcc-*-*-*" will match
"gcc-2-95-".  How about if you make the unknown case "gcc-X-Y-UNKNOWN"
instead of "gcc-X-Y-".

Michael C

2004-06-09  Andrew Cagney  <cagney@gnu.org>

	* lib/compiler.cc, lib/compiler.c: Append __GNUC_PATCHLEVEL__ to
	the compiler_info.
	* gdb.base/structs.exp (test_struct_calls): Check for gcc-3-3-*
	instead of gcc-3-3.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]