This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: -file-list-exec-source-files


On Wed, Jun 02, 2004 at 10:35:22PM -0400, Bob Rossi wrote:
> On Wed, Jun 02, 2004 at 03:13:24PM -0400, Elena Zannoni wrote:
> > Bob Rossi writes:
> >  > 
> >  > The dwarf2 specs say that the name is in the form ":pathname" or
> >  > "hostname:pathname". Should we worry about the hostname? Does gcc emit
> >  > that?  I have looked at a few executables and didn't see the hostname
> >  > part.
> >  > 
> >  > Would you like me to try to take into account the 
> >  > hostname:dirname? Is the hostname allowed to have a ':' in it?
> >  > 
> > 
> > Oh, no. Just the formatting. 
> 
> Ok, I'll commit it as soon as I get the chance.

Ok, I had to make one small change to dwarf2read.c, it was
   pst->dirname = xstrdup (comp_unit_die.dirname);
it now is
   if (comp_unit_die.dirname)
     pst->dirname = xstrdup (comp_unit_die.dirname);

This fixed a crash in the testsuite.


Also, I changed both mi-file.exp and mi2-file.exp from
   global srcfile
   global srcdir
   global subdir
   set srcfilepath [string_to_regexp ${srcdir}/${subdir}/${srcfile}]

   "111\\\^done,line=\"23\",file=\"${srcfilepath}\",fullname=...

to
   "111\\\^done,line=\"23\",file=\".*/${srcfile}\",fullname=...

This had nothing to do with this patch. The testcase was failing with a
clean checkout and run of the testsuite.

Is this OK to commit? If so, I will do it today.

Thanks,
Bob Rossi
   


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]