This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: Turn on Ada support


On Wed, Jun 09, 2004 at 02:23:18AM -0500, Jim Blandy wrote:


The changes to symtab.c, symfile.c, defs.h, and gdbtypes.h are fine.


I don't like the braces around the lone 'return' statements in
symtab.c, though.  I don't think they add much, although what's
probably more germane is that it's not the typical practice elsewhere
in the code.


I'm not sure if those parts will work without the Makefile.in changes,
and I'm not in favor of the Makefile.in changes yet.

The problem is that the Ada language support has never been reviewed. It's in the repository as a code dump under the assumption that it will
be reviewed before we start actively using it. So in my opinion, to
review this patch we first have to review those files.

Correct.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]