This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]: Turn on Ada support
- From: Jim Blandy <jimb at redhat dot com>
- To: Paul Hilfinger <hilfingr at gnat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 09 Jun 2004 02:23:18 -0500
- Subject: Re: [RFA]: Turn on Ada support
- References: <20040608090758.C59CAF2940@nile.gnat.com>
The changes to symtab.c, symfile.c, defs.h, and gdbtypes.h are fine.
I don't like the braces around the lone 'return' statements in
symtab.c, though. I don't think they add much, although what's
probably more germane is that it's not the typical practice elsewhere
in the code.
> gdb/ChangeLog:
>
> 2004-06-03 Paul N. Hilfinger <Hilfinger@gnat.com>
>
> Turn on initial Ada support (mainly expression evaluation).
>
> * Makefile.in (ada_lex_c): Define
> (HFILES_NO_SRCDIR): Add ada-lang.h.
> (COMMON_OBS): Add ada-lang.o, ada-typeprint.o, ada-valprint.o,
> ada-tasks.o.
> (YYOBJ): Add ada-exp.o.
> (rule .l.c): Generalize to not mention ada.
> (ada-lex.o): Remove (ada-lex.c is included by ada-exp.y).
> (ada-lang.o): Add dependencies on completer.h, gdb_obstack.h,
> hashtab.h.
> (ada-tasks.o): Add dependency on gdb_string.h.
> (ada-valprint.o): Add dependency on gdb_string.h.
>
> * symtab.c: Add dependency on ada-lang.h.
> (symbol_natural_name): Add Ada case.
> (symbol_demangled_name): Add Ada case.
> (symbol_search_name): Add Ada case.
>
> * symfile.c (init_filename_language_table): Add extensions for
> Ada.
>
> * defs.h (enum language): Add language_ada.
>
> * gdbtypes.h (TYPE_FLAG_FIXED_INSTANCE): Define.