This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: fix assertions; handle endianness more directly
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Jim Blandy <jimb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 4 Jun 2004 15:39:34 -0700
- Subject: Re: RFA: fix assertions; handle endianness more directly
- Organization: Red Hat
- References: <vt24qpsxsg1.fsf@zenia.home>
On 03 Jun 2004 16:06:06 -0500
Jim Blandy <jimb@redhat.com> wrote:
> 2004-06-02 Jim Blandy <jimb@redhat.com>
>
> * ppc-linux-nat.c (store_register, fetch_register): Remove
> incorrect assertions. Simplify and generalize handling of
> transfers whose sizes are not multiples of, or less than, sizeof
> (PTRACE_XFER_TYPE).
Okay, except for:
> ! for (bytes_transferred = 0;
> ! bytes_transferred < DEPRECATED_REGISTER_RAW_SIZE (regno);
> ! bytes_transferred += sizeof (PTRACE_XFER_TYPE))
Please use register_size() here instead of DEPRECATED_REGISTER_RAW_SIZE().
(I notice that you made this substitution elsewhere.)
Kevin