This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: fix assertions; handle endianness more directly


On 03 Jun 2004 16:06:06 -0500
Jim Blandy <jimb@redhat.com> wrote:

> 2004-06-02  Jim Blandy  <jimb@redhat.com>
> 
> 	* ppc-linux-nat.c (store_register, fetch_register): Remove
> 	incorrect assertions.  Simplify and generalize handling of
> 	transfers whose sizes are not multiples of, or less than, sizeof
> 	(PTRACE_XFER_TYPE).

Okay, except for:

> !   for (bytes_transferred = 0;
> !        bytes_transferred < DEPRECATED_REGISTER_RAW_SIZE (regno);
> !        bytes_transferred += sizeof (PTRACE_XFER_TYPE))

Please use register_size() here instead of DEPRECATED_REGISTER_RAW_SIZE().
(I notice that you made this substitution elsewhere.)

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]