This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: gdb.base/charset.exp: don't use expect_out without regexp groups
- From: Jim Blandy <jimb at redhat dot com>
- To: mec dot gnu at mindspring dot com (Michael Elizabeth Chastain)
- Cc: gdb-patches at sources dot redhat dot com
- Date: 04 Jun 2004 16:53:42 -0500
- Subject: Re: RFA: gdb.base/charset.exp: don't use expect_out without regexp groups
- References: <20040604161852.ECE2B4B104@berman.michael-chastain.com>
mec.gnu@mindspring.com (Michael Elizabeth Chastain) writes:
> Proofread, looks okay to me.
>
> Testing? Did you test it?
Tested on powerpc-ibm-aix4.3.3.0, powerpc-unknown-linux-gnu, and
i686-pc-linux-gnu.
> In the ChangeLog, you say "remove commented-out code", but in the
> patch, there's no removal of commented-out code.
Thanks --- I decided to submit that as a separate patch, but forgot to
update the ChangeLog entry. Corrected:
2004-06-03 Jim Blandy <jimb@redhat.com>
* gdb.base/charset.exp: Don't refer to $expect_out(1,string) in
cases where the regexp has no groups; this grabs random text from
the previous test suite, whatever that was.
Index: gdb/testsuite/gdb.base/charset.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.exp,v
retrieving revision 1.3
diff -c -p -r1.3 charset.exp
*** gdb/testsuite/gdb.base/charset.exp 26 Feb 2004 17:23:23 -0000 1.3
--- gdb/testsuite/gdb.base/charset.exp 4 Jun 2004 04:30:40 -0000
*************** gdb_expect {
*** 200,206 ****
-re "\\.\r\n$gdb_prompt $" {
#set host_charset_list $expect_out(1,string)
- set charsets($expect_out(1,string)) 1
pass "capture valid host charsets"
}
--- 200,205 ----