This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] symtab.c: Search section table when fixing up a symbol's section

From: Jim Blandy <jimb at redhat dot com>
To: Kevin Buettner <kevinb at redhat dot com>
Cc: gdb-patches at sources dot redhat dot com
Date: 18 May 2004 01:10:43 -0500
Subject: Re: [RFA] symtab.c: Search section table when fixing up a symbol's section
References: <20040517120219.5fad9bc0@saguaro> <vt2n04693gv.fsf@zenia.home><20040517142316.3b0f4320@saguaro>

Kevin Buettner <kevinb@redhat.com> writes:
> On 17 May 2004 15:57:20 -0500
> Jim Blandy <jimb@redhat.com> wrote:
> 
> > Oh, endaddr *is* inclusive.  Well done.
> 
> Actually, I don't think it is:
> 
>     CORE_ADDR endaddr;		/* 1+highest address in section */
> 
> I'm appending a revised patch.

Damn.  It *should* be inclusive; otherwise you can't really represent
ranges that abut the top of the address space when CORE_ADDR is no
larger than a target address.

Well, I'm glad we caught it.

> > I'm going to leave this for others' comments for a few days, but other
> > than that, it looks good to me.
> 
> Thanks for looking it over.

References:
- [RFA] symtab.c: Search section table when fixing up a symbol'ssection
  - From: Kevin Buettner
- Re: [RFA] symtab.c: Search section table when fixing up a symbol's section
  - From: Jim Blandy
- Re: [RFA] symtab.c: Search section table when fixing up a symbol'ssection
  - From: Kevin Buettner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]