This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Fix watchpoints on s390
- From: "Eli Zaretskii" <eliz at gnu dot org>
- To: Ulrich Weigand <weigand at i1 dot informatik dot uni-erlangen dot de>
- Cc: gdb-patches at sources dot redhat dot com, orjan dot friberg at axis dot com, kettenis at chello dot nl, drow at false dot org
- Date: Tue, 11 May 2004 09:24:19 +0200
- Subject: Re: [PATCH] Fix watchpoints on s390
- References: <200405101738.TAA07374@faui1d.informatik.uni-erlangen.de>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
> Date: Mon, 10 May 2004 19:38:29 +0200 (CEST)
>
> this is the second attempt to fix watchpoints on s390 by using
> STOPPED_BY_WATCHPOINT instead of target_stopped_data_address
> in bpstat_stop_status to find out whether the target stopped
> due to a hardware watchpoint.
>
> As STOPPED_BY_WATCHPOINT requires an argument not available
> in breakpoint.c, and furthermore some targets define this
> macro so as to access other local variables not even passed
> as arguments, calling this macro from anywhere else is not
> trivial.
>
> Thus, this patch simply remembers the return value of
> STOPPED_BY_WATCHPOINT in handle_inferior_event, and passes
> *that* as argument to bpstat_stop_status. This should
> work on all targets ...
This patch is fine with me.
Thanks.