This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix watchpoints on s390


> From: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
> Date: Mon, 10 May 2004 19:38:29 +0200 (CEST)
> 
> this is the second attempt to fix watchpoints on s390 by using
> STOPPED_BY_WATCHPOINT instead of target_stopped_data_address
> in bpstat_stop_status to find out whether the target stopped
> due to a hardware watchpoint.
> 
> As STOPPED_BY_WATCHPOINT requires an argument not available
> in breakpoint.c, and furthermore some targets define this
> macro so as to access other local variables not even passed
> as arguments, calling this macro from anywhere else is not
> trivial.
> 
> Thus, this patch simply remembers the return value of 
> STOPPED_BY_WATCHPOINT in handle_inferior_event, and passes
> *that* as argument to bpstat_stop_status.  This should
> work on all targets ...

This patch is fine with me.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]