This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Make QUIT work
- From: Daniel Jacobowitz <drow at false dot org>
- To: Michael Snyder <msnyder at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com, Elena Zannoni <ezannoni at redhat dot com>
- Date: Sat, 8 May 2004 00:51:16 -0400
- Subject: Re: [RFA] Make QUIT work
- References: <409C5394.3070208@redhat.com>
On Sat, May 08, 2004 at 03:27:16AM +0000, Michael Snyder wrote:
> Elena, here's something that must have fallen thru the cracks
> at some point. handle_sigint needs to set quit_flag -- or else
> QUIT won't quit. As is currently, QUIT won't work unles
> immediate_quit is set -- and I'm pretty sure that's not how
> it was intended to work.
>
See the patch Joel submitted for this last August. Elena deferred it
to after 6.1 because just setting quit_flag invokes both sets of event
handling machinery, potentially quitting twice.
> 2004-05-08 Michael Snyder <msnyder@redhat.com>
>
> * event-top.c (handle_sigint): Set quit_flag, so that QUIT
> will work the next time it's invoked.
>
> Index: event-top.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/event-top.c,v
> retrieving revision 1.33
> diff -p -r1.33 event-top.c
> *** event-top.c 28 Feb 2004 18:04:36 -0000 1.33
> --- event-top.c 8 May 2004 03:22:55 -0000
> *************** void
> *** 950,955 ****
> --- 950,956 ----
> handle_sigint (int sig)
> {
> signal (sig, handle_sigint);
> + quit_flag=1;
>
> /* If immediate_quit is set, we go ahead and process the SIGINT right
> away, even if we usually would defer this to the event loop. The
--
Daniel Jacobowitz