Re: [PATCH] implements MI "-file-list-exec-sections" (updated)

[Andrew Cagney <cagney at gnu dot org>]

Lets separate out a few simpler parts:

----

 Index: doc/gdb.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
> retrieving revision 1.202
> diff -u -3 -p -r1.202 gdb.texinfo
> --- doc/gdb.texinfo	28 Mar 2004 12:22:55 -0000	1.202
> +++ doc/gdb.texinfo	22 Apr 2004 21:44:09 -0000
> @@ -14574,7 +14574,7 @@ Elena Zannoni.
>  
>  @item @var{mi-command} @expansion{}
>  @code{[ @var{token} ] "-" @var{operation} ( " " @var{option} )*
> -@code{[} " --" @code{]} ( " " @var{parameter} )* @var{nl}}
> +[ " --" ] ( " " @var{parameter} )* @var{nl}}
>  
>  @item @var{token} @expansion{}
>  "any sequence of digits"
> @@ -14698,13 +14698,13 @@ depending on the needs---this is still i
>  @code{@var{console-stream-output} | @var{target-stream-output} | @var{log-stream-output}}
>  
>  @item @var{console-stream-output} @expansion{}
> -@code{"~" @var{c-string}}
> +@code{"~" @var{c-string} @var{nl}}
>  
>  @item @var{target-stream-output} @expansion{}
> -@code{"@@" @var{c-string}}
> +@code{"@@" @var{c-string} @var{nl}}
>  
>  @item @var{log-stream-output} @expansion{}
> -@code{"&" @var{c-string}}
> +@code{"&" @var{c-string} @var{nl}}
>  
>  @item @var{nl} @expansion{}
>  @code{CR | CR-LF}

This part all looks correct, can you just post it separatly with a 
ChangeLog.

----

> -static void core_files_info (struct target_ops *);
> +static void core_files_info (struct target_ops *, struct ui_out *);

Again, just this part (through out) is all ok, can you please post it.

----

Now the fun bit ...

You'll have noticed I sent out an e-mail asking about ``inferior vs 
target'', lets ignore that question for this output...

> +@smallexample
> +(@value{GDBP})
> +123-file-list-exec-sections
> +~"Symbols from \"/var/home/ouk/projects/ht20/testproject/test-g\".\n"
> +123^done,targets=[

List of targets reflecting the target stack, nice.

{target-type-long="Local exec file",target-type-short="exec",

here ``target-'' is implied, so would just:

	short-name=
	long-name=
	entry-point=

be better?

> +filename="/var/home/ouk/projects/ht20/testproject/test-g",file-type="elf32-i386",
> +target-entrypoint="0x08048380",sections=[

List of sections, again nice.

> +{start-address="0x08048134",end-address="0x08048147",section-name=".interp"},
> +{start-address="0x08048148",end-address="0x08048168",section-name=".note.ABI-tag"},
> +{start-address="0x08048168",end-address="0x08048198",section-name=".hash"},
> +{start-address="0x08048198",end-address="0x08048208",section-name=".dynsym"},
> +{start-address="0x08048208",end-address="0x080482af",section-name=".dynstr"},
> +{start-address="0x080482b0",end-address="0x080482be",section-name=".gnu.version"},
> +{start-address="0x080482c0",end-address="0x08048300",section-name=".gnu.version_r"},
> +{start-address="0x08048300",end-address="0x08048308",section-name=".rel.dyn"},
> +{start-address="0x08048308",end-address="0x08048320",section-name=".rel.plt"},
> +{start-address="0x08048320",end-address="0x08048337",section-name=".init"},
> +{start-address="0x08048338",end-address="0x08048378",section-name=".plt"},
> +{start-address="0x08048380",end-address="0x08048570",section-name=".text"},
> +{start-address="0x08048570",end-address="0x0804858b",section-name=".fini"},
> +{start-address="0x0804858c",end-address="0x080485a0",section-name=".rodata"},
> +{start-address="0x080485a0",end-address="0x080485b4",section-name=".eh_frame_hdr"},
> +{start-address="0x080485b4",end-address="0x080485f0",section-name=".eh_frame"},
> +{start-address="0x080495f0",end-address="0x080495fc",section-name=".data"},
> +{start-address="0x080495fc",end-address="0x080496dc",section-name=".dynamic"},
> +{start-address="0x080496dc",end-address="0x080496e4",section-name=".ctors"},
> +{start-address="0x080496e4",end-address="0x080496ec",section-name=".dtors"},
> +{start-address="0x080496ec",end-address="0x080496f0",section-name=".jcr"},
> +{start-address="0x080496f0",end-address="0x0804970c",section-name=".got"},
> +{start-address="0x0804970c",end-address="0x08049710",section-name=".bss"}]}]
> +(@value{GDBP})
> +@end smallexample

I like it.  But lets get the other changes in first.

Sorry for the delay.

Andrew