This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Display of read/access watchpoints when HAVE_NONSTEPPABLE_WATCHPOINT
>>>>> "Orjan" == Orjan Friberg <orjan.friberg@axis.com> writes:
Orjan> Orjan Friberg wrote:
>> Agreed. I am quite happy to live with your suggested solution,
>> at least for now. I certainly don't have the audacity to suggest
>> such changes should be made to accomodate a target that isn't even
>> submitted yet ;) .
Orjan> ... which brings me back to the reason for re-opening this
Orjan> thread: getting Paul Koning's patch to make read/access
Orjan> watchpoints work when HAVE_NONSTEPPABLE_WATCHPOINT is defined
Orjan> accepted.
Orjan> I did change one thing in Paul's patch, which should be
Orjan> highlighted: the change in bpstat_stop_status previously
Orjan> applied to bp_watchpoint types also (in addition to
Orjan> bp_hardware_watchpoint, bp_read_watchpoint, and
Orjan> bp_access_watchpoint), but as far as I can tell
Orjan> target_stopped_data_address applies only to hardware-assisted
Orjan> watchpoints, not software watchpoints. Maybe that needs to be
Orjan> made more clear in the comment.
Thanks. I developed the original patch on a platform with hardware
watchpoints (MIPS SB-1) so I don't know if it needs to be restricted
only to hardware watchpoints or should apply to both types.
paul