This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] New dwarf2_attribute_true_p function in dwarf2read.c (take 2)
- From: Joel Brobecker <brobecker at gnat dot com>
- To: Jim Blandy <jimb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 19 Apr 2004 10:09:32 -0700
- Subject: Re: [RFA] New dwarf2_attribute_true_p function in dwarf2read.c (take 2)
- References: <20040416212108.GJ22414@gnat.com> <vt2zn98wjin.fsf@zenia.home>
> > 2004-04-16 Joel Brobecker <brobecker@gnat.com>
> >
> > * dwarf2read.c (dwarf2_attribute_true_p): New function.
> > (die_is_declaration): Use the function above. Add some comments.
> >
> > Tested on x86-linux, no regression.
> >
> > OK to apply?
>
> I'd like the comment for dwarf2_attribute_true_p to specifically say
> that it's meant for use with attributes with DW_FORM_flag values.
>
> (Trying to read more carefully this time...) Looks okay, otherwise.
I can add a comment, or if you prefer, I can change the name to make
it more explicit. Something like "form_flag_attribute_true_p", for
instance, or "dw_form_flag_attribute_true_p".
--
Joel