This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] Fix unwind handling for hppa
On Sat, Apr 17, 2004 at 10:20:27AM -0700, Randolph Chung wrote:
> > > + if (frame_relative_level (next_frame) >= 0 ||
> > > + frame_pc_unwind (next_frame) >=
> > > + hppa_skip_prologue (frame_func_unwind (next_frame)))
> >
> > - your formatting is wrong; operators always come at the beginning
> > of the line.
>
> ok, i have to go and read the coding style doc some more since it is
> very different from what i'm used to :)
>
> > - Checking the frame level is wrong. It's wrong both in practice and
> > in principle: in practice, the next frame could be a dummy frame
> > or a signal frame. There's a test case in the testsuite which
> > covers this.
>
> mmmm, ok. so if i just do:
>
> if (frame_pc_unwind (next_frame)
> >= hppa_skip_prologue (frame_func_unwind (next_frame)))
>
> then it's ok? or is there a more efficient/correct mechanism to get to
> this info?
Beats me. I guess that might work. At that point you're more or less
running the prologue analyzer despite having unwind data; I'm not sure
how I feel about that. But it does seem pragmatically useful.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer