This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFC] Work around GCC compiler bugs in frame.c


   Date: Thu, 15 Apr 2004 16:56:04 -0400
   From: Andrew Cagney <cagney@gnu.org>

   > I've always considered functions return a struct (as opposed to a
   > pointer to a struct) bad programming style, but now I know why.  The
   > following code in frame.c triggers a bug in the system compiler on
   > OpenBSD/vax (which is basically GCC 2.95.3 with some local patches):
   > 
   >       && frame_id_eq (get_frame_id (this_frame),
   >                       get_frame_id (this_frame->next))

   Would introducing frame_eq(), frame_inner() be more robust?  Either way 
   you'll likely want to add a comment.

That would make sense I guess.  It's the frame that we care about, not
the ID.  I'll check wrap something up...

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]