This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[obvious commited PATCH]: comment touch-ups in frame.c


I had to read through frame.c today and saw a few small typeos and the like while reading it; corrected them as I went along. I've checked in the patch at the end of the e-mail.

As an aside, in the struct frame_info decl, there's this comment:

  /* NOTE: cagney/2002-04-05: Perhaps a level of ``-1'' should be
     reserved to indicate a bogus frame - one that has been created
     just to keep GDB happy (GDB always needs a frame).  For the
     moment leave this as speculation.  */
  int level;

Of course level == -1 means the sentinel frame today, so I'm guessing this comment is out of date. Oh, and one comment I didn't know how to fix was this one in frame_register():

  /* Ulgh!  Old code that, for lval_register, sets ADDRP to the offset
     of the register in the register cache.  It should instead return
     the REGNUM corresponding to that register.  Translate the .  */

I'm not exactly sure what the rest of this sentence was meant to be.

2004-04-16 Jason Molenda (jmolenda@apple.com)

* frame.c: Minor typeo corrections in comments.

Attachment: pa.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]