This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] Bring QNX Neutrino support forward.
- From: Daniel Jacobowitz <drow at false dot org>
- To: Kris Warkentin <kewarken at qnx dot com>
- Cc: "Gdb-Patches at Sources dot Redhat dot Com" <gdb-patches at sources dot redhat dot com>
- Date: Wed, 31 Mar 2004 17:21:20 -0500
- Subject: Re: [patch] Bring QNX Neutrino support forward.
- References: <4060A9C0.1090906@qnx.com>
Some small comments.
On Tue, Mar 23, 2004 at 04:18:56PM -0500, Kris Warkentin wrote:
> ChangeLog entry:
> * nto-tdep.h: Include osabi.h. Prototypes for generic Neutrino
Leading tabs in the ChangeLog entry, please :) Post what you would
check in.
> +#define nto_fetch_link_map_offsets \
> +(current_nto_target.nto_fetch_link_map_offsets)
I believe this should be indented. I'm not sure how far, I usually use
two spaces.
> - return openp (buf, 1, solib, o_flags, 0, temp_pathname);
> + /* Don't assume basename() isn't destructive. */
> + base = strrchr (solib, '/');
> + if (!base)
> + base = solib;
> + else
> + base++; /* Skip over '/'. */
There's an lbasename in libiberty, for this reason. You should use
that instead.
> + ret = openp (buf, 1, base, o_flags, 0, temp_pathname);
> + if (ret < 0 && base != solib)
> + {
> + sprintf (arch_path, "/%s", solib);
> + ret = open (arch_path, o_flags, 0);
Er... automatically falling back to the host library? Why?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer