This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/hppa] Fix pb in inferior function call


> > 2004-04-30  J. Brobecker  <brobecker@gnat.com>
> > 
> >         * hppa-tdep.c (hppa32_push_dummy_call): Set the Stack Pointer.
> >         (hppa64_push_dummy_call): Likewise.
> > 
> > The change has been tested on hppa32-hpux11.00, and it fixes roughly
> > 500 regressions (yay! :-). It also brings the duration of the testsuite
> > run from several hours down to about 45 mins.
> > 
> > I didn't test the change for hppa64, but it seems pretty obvious if
> > the hppa32 one is correct.
> > 
> > OK to apply?
> 
> OK.  You're right; push_dummy_call should update the stack pointer
> itself.

Thanks. Checked in.

Andrew asked:
> Joel, do you think a pull up of the hppa stuff onto the 6.1 branch would
> be useful?  (it can only break HP/UX so is "mostly harmless").

Yes, I think so. I tested and then committed the attached patch for the
branch (there was one minor edit to make).

2004-04-31  J. Brobecker  <brobecker@gnat.com>
  
        * hppa-tdep.c (hppa32_push_dummy_call): Set the Stack Pointer.
        (hppa64_push_dummy_call): Likewise.

Thanks,
-- 
Joel

Attachment: hppa-tdep-branch.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]