This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/mips] Fix reread.exp on mips-linux
- From: Daniel Jacobowitz <drow at false dot org>
- To: Andrew Cagney <cagney at gnu dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 29 Mar 2004 13:02:04 -0500
- Subject: Re: [rfa/mips] Fix reread.exp on mips-linux
- References: <20040325015317.GA10143@nevyn.them.org> <406753AE.6090401@gnu.org>
On Sun, Mar 28, 2004 at 05:37:34PM -0500, Andrew Cagney wrote:
> >My goof, from two years or so ago. This is allocated on the objfile
> >obstack, and we stashed it in obj_private; but obj_private doesn't get
> >cleared. If we put it in the new objfile_data machinery like a good little
> >interface user, then it gets cleared at the right time. This prevents
> >segfaulting as soon as the executable changes.
> >
> >OK for head/6.1?
>
> Ok for mainline. For the moment sit on it for the branch.
Committed both, with your later approval for the branch. Thanks.
> >- priv = (struct mips_objfile_private *) sec->objfile->obj_private;
> can something from this be ARIed?
Any reference to obj_private, I think. This was the last one outside
of HPPA/HPUX code:
drow@nevyn:/opt/src/gdb/src/gdb% grep -lr obj_private .
./hppa-tdep.c
./hpread.c
./pa64solib.c
./somread.c
./somsolib.c
./config/pa/tm-hppa.h
[And some changelogs, and the definition in objfiles.h]
If someone wants to fix that, we can then remove obj_private entirely.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer