This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Andrew,
It's probably too late now, but I have the feeling this new tramp-frame.c is not generic enough. It assumes fixed-length instructions (which makes it unsuitable for IA-32 and AMD64)
the arbitrary number 8 for the number of instructions (which makes it not quite suitable for SPARC).
over-engineered to me :-(.
Anyway, you might want to conseider the attached patch, which makes the comments catch up with reality. The extra whitespace is there to guide the eye and make the distinction between the instruction sequence members and the initialization function clear.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |