This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rfc] Deprecate SIGTRAMP_START SIGTRAMP_END


Hello,

The attached deprecates SIGTRAMP_START and SIGTRAMP_END. These were made obsolete by PC_IN_SIGTRAMP (which in turn has been made obsolete by signal trampoline frame sniffers).

Note that blockframe.c:find_pc_partial_function contains what I consider to be broken references to these macros -- typically it is only possible to determine the location of a signal trampoline by doing a detailed analysis of the inferior (i.e., unwinding frames and examining instructions) yet that function is ment to work with just static information. I've added a comment explaining this.

comments?

I'll look to commit this in a week.

I've checked this in.


Andrew

2004-03-16 Andrew Cagney <cagney@redhat.com>

* gdbarch.sh (SIGTRAMP_START, SIGTRAMP_END): Deprecate.
* gdbarch.h, gdbarch.c: Re-generate.
* i386obsd-tdep.c (i386obsd_init_abi): Update.
* i386nbsd-tdep.c (i386nbsd_init_abi): Update.
* i386bsd-tdep.c (i386bsd_init_abi): Update.
* config/vax/tm-vaxbsd.h (DEPRECATED_SIGTRAMP_END) (DEPRECATED_SIGTRAMP_START): Update.
* config/m68k/tm-nbsd.h (DEPRECATED_SIGTRAMP_END) (DEPRECATED_SIGTRAMP_START): Update.
* blockframe.c (find_pc_sect_partial_function): Update.
* arch-utils.c (legacy_pc_in_sigtramp): Update.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]