This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix gdb1476.exp on s390*


Hello,

this patch fixes the gdb.base/gdb1476.exp test case (backtrace from NULL
function pointer call).

When calling via an invalid function pointer, what we should do is simply
unwind the PC from the return address register and continue. This is
exactly what is done to unwind from a PLT stub as well, so the patch simply uses the PLT frame unwinder to handle this case as well.

While that might be true, I don't know that its the job of something called "PLTSTUB". I can think of either:
- renaming pltstub to something that matches its new purpose (just "stub"?)
- using the default unwinder
thoughts?


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]