This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[commit] Zap XPASS from watchpoints.exp; Was: [PATCH] Remove XPASSon s390*
- From: Andrew Cagney <cagney at gnu dot org>
- To: Ulrich Weigand <weigand at i1 dot informatik dot uni-erlangen dot de>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 22 Mar 2004 09:40:57 -0500
- Subject: [commit] Zap XPASS from watchpoints.exp; Was: [PATCH] Remove XPASSon s390*
- References: <200403171918.UAA09557@faui1d.informatik.uni-erlangen.de>
Hello,
this patch removes an XPASS in the gdb.base/watchpoint.exp test case
by calling clear_xfail for s390* (as is already done for many other
targets).
Hmm, you tripped over a landmine :-(. In the past many of GDB's
testcases were incorrectly XFAILed (as a way of hiding design flaws that
were thought to be unfixable / or the individual had no intention of
fixing ...). XFAIL only applies to problems eXternal to GDB (OS bugs,
...) which these are not.
I've removed the offending XFAIL junk.
Andrew
2004-03-22 Andrew Cagney <cagney@redhat.com>
* gdb.base/watchpoint.exp (test_stepping): Delete bogus XFAILs
hiding problems with DEPRECATED_CALL_DUMMY_BREAKPOINT_OFFSET.
Problem identified by Ulrich Weigand.
Index: gdb.base/watchpoint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/watchpoint.exp,v
retrieving revision 1.10
diff -u -r1.10 watchpoint.exp
--- gdb.base/watchpoint.exp 6 Oct 2003 19:31:43 -0000 1.10
+++ gdb.base/watchpoint.exp 22 Mar 2004 14:23:09 -0000
@@ -374,31 +374,8 @@
gdb_test "break func2 if 0" "Breakpoint.*at.*"
gdb_test "p \$func2_breakpoint_number = \$bpnum" " = .*"
- # The problem is that GDB confuses stepping through the call
- # dummy with hitting the breakpoint at the end of the call dummy.
- # Will be fixed once all architectures define
- # DEPRECATED_CALL_DUMMY_BREAKPOINT_OFFSET.
- setup_xfail "*-*-*"
- # This doesn't occur if the call dummy starts with a call,
- # because we are out of the dummy by the first time the inferior
- # stops.
- clear_xfail "arm*-*-*"
- clear_xfail "xscale*-*-*"
- clear_xfail "d10v*-*-*"
- clear_xfail "m68*-*-*"
- clear_xfail "i*86*-*-*"
- clear_xfail "vax-*-*"
- # The following architectures define DEPRECATED_CALL_DUMMY_BREAKPOINT_OFFSET.
- clear_xfail "alpha-*-*"
- clear_xfail "mips*-*-*"
- clear_xfail "sparc-*-*"
- clear_xfail "hppa*-*-*bsd*"
- # It works with the generic inferior function calling code too.
- clear_xfail "mn10300*-*-*"
- # The following architectures define CALL_DUMMY_HAS_COMPLETED.
- clear_xfail "hppa*-*-*hpux*"
gdb_test "p func1 ()" "= 73" \
- "calling function with watchpoint enabled"
+ "calling function with watchpoint enabled"
#
# "finish" brings us back to main.