This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC patch mi-cmds.c table format (pedantic)



On Mar 18, 2004, at 11:55 AM, Andrew Cagney wrote:


First, have a look at:
http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit- trail&database=gdb&pr=496


Ah, I hadn't seen that.

How do you envision the cli-mapped mi commands working (e.g. -gdb-set), where files in the gdb/ directory are registering the commands?

There shouldn't be cli-mapped mi commands. Both the MI and CLI should share a common framework. However, in the mean time, I guess such a table should be pump-primed with all the cli-mapped mi entries.


OK I'll come up with a real/tested patch. The trailing initializers -- you don't mean this kind of change, do you?

-  { "exec-step", { NULL, 0 }, mi_cmd_exec_step},
+  { "exec-step", { NULL, 0 }, mi_cmd_exec_step, NULL},


I think you were talking about the final NULL entry.

Skip them as well, I don't see the benefit.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]