This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa+6.1]: Revised patch for PR c++/1553


David Carlton writes:
 > Here's a revision for my patch for PR c++/1553 that I posted a couple
 > of weeks ago.  The stuff that was in that patch hasn't changed (except
 > for syncing it up with current sources), but this version also
 > includes changes to determine_prefix.  Specifically, it fixes a bug in
 > that code that Daniel pointed out, and it rewrites determine_prefix to
 > use my new determine_class_name function (so that all the class name
 > lookup stuff is in one place) and to look at TYPE_TAG_NAME (to avoid
 > recalculating the same name over and over again if possible).
 > 
 > The determine_prefix stuff could be a separate patch from my earlier
 > changes; I just wanted to get it submitted now because it's possible
 > that there will be a hiccup in my copyright assignment.  Also, it
 > seems like a good idea to get patches into 6.1 as early as possible,
 > to increase the amount of testing that they'll get.
 > 
 > I couldn't come up with any test cases for the new part of the patch;
 > it depends very much on how the compiler is generating output. :-(
 > 
 > Tested on i686-pc-linux-gnu, DWARF-2, several different GCC versions.
 > Ok for mainline and 6.1?
 > 

seems ok, however I wasn't able to apply it cleanly.
Also, there are a couple of C++ style comments that should go.

elena


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]