This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [ob(ish)/committed] Fix SEGV in hppa_frame_cache
- From: Joel Brobecker <brobecker at gnat dot com>
- To: Andrew Cagney <cagney at gnu dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 10 Mar 2004 12:09:13 -0800
- Subject: Re: [ob(ish)/committed] Fix SEGV in hppa_frame_cache
- References: <20040305050546.GC1226@gnat.com> <40491E6B.1000900@gnu.org>
> >Unfortunately, that return causes the return value to be undefined.
> >And we later crash while trying to dereference this undefined value
> >in hppa_frame_this_id().
> >
> >So I fixed it with the attached patch. This fixed 8 tests.
> >I didn't commit it to the 6.1 branch yet, as I wanted to wait for
> >Andrew's comments first. Don't want to disturb the branch too much.
>
> For HP/UX, I think we'll be doing frequent pull-ups - this will be just
> the first of many bugs :-( Definitly go ahead.
Sorry for the delay. I just committed this change on the branch.
2004-03-10 J. Brobecker <brobecker@gnat.com>
* hppa-tdep.c (hppa_frame_cache): Avoid undefined return value.
Thanks,
--
Joel
PS: I am unfortunately a bit busy at the moment, but I'd like to reread
your comments again, and send mine if needed. So I'm keeping your message
in my inbox...