This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] use frame IDs to detect function calls while stepping
- From: Joel Brobecker <brobecker at gnat dot com>
- To: Andrew Cagney <cagney at gnu dot org>
- Cc: kettenis at gnu dot org, Elena Zannoni <ezannoni at redhat dot com>,gdb-patches at sources dot redhat dot com
- Date: Tue, 2 Mar 2004 14:07:22 -0800
- Subject: Re: [RFA] use frame IDs to detect function calls while stepping
- References: <20040205044119.GC18961@gnat.com> <20040205171324.GF18961@gnat.com> <16418.37058.65446.669052@localhost.redhat.com> <20040207040049.GH18961@gnat.com> <403F60F1.7020902@gnu.org> <20040301194801.GK1051@gnat.com> <20040301235239.GP1051@gnat.com> <20040302061642.GW1051@gnat.com> <4044ACBF.1020302@gnu.org>
> How about this as a compromize:
>
> - in 6.1
> your original patch (but with a comment saying that the
> + if (IN_SOLIB_CALL_TRAMPOLINE (stop_pc, ecs->stop_func_name))
> is a hack and shouldn't be included in the mainline)
>
> - in mainline:
> Assuming Mark's ok with the sparc changes, your patch without that part?
>
> This way 6.1 is robust regardless of which SPARC architecture code is in
> place.
it looks reasonable, but it'd be nice to have Mark's opinion on the
unwinder problem. How about we let it sit for another day or two before
we commit anything?
Also, do we need this change in 6.1? It seemed like a pretty minor bug
that I managed to produce on Tru64 only. Or were there other occurrences
of this bug?
--
Joel