This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [ob] Remove initializations of memset'd structure
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: Eli Zaretskii <eliz at elta dot co dot il>
- Cc: Daniel Jacobowitz <drow at false dot org>,gdb-patches at sources dot redhat dot com
- Date: Tue, 17 Feb 2004 09:30:06 -0500
- Subject: Re: [ob] Remove initializations of memset'd structure
- References: <20040216211516.GA17055@nevyn.them.org><uk72m2o25.fsf@elta.co.il>
Eli Zaretskii writes:
> > Date: Mon, 16 Feb 2004 16:15:16 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> >
> > - MSYMBOL_TYPE (m) = mst_unknown;
>
> This part of the patch seems to assume that mst_unknown has the value
> zero. Should we have such assumptions in the code?
Yes, in symtab.h mst_unknown is 0. However, that got me puzzled as
well, and I think it warrants a comment. Daniel, please add something
in the function you touched.
elena