Re: [RFA]: pending breakpoint support [2/3]

["J. Johnston" <jjohnstn at redhat dot com>]

Daniel Jacobowitz wrote:
> On Wed, Jan 21, 2004 at 04:03:28PM -0500, Jeff Johnston wrote:
>
> > The following makes changes to the testsuite to accomodate the pending 
> > breakpoint support.
> > A new test case has been added to test pending breakpoint support.
> >
> > Ok to commit?
>
>
> Needs a tweak.
>
>
> > -gdb_test "b langs0" "Function \"langs0\" not defined\.|Breakpoint .* (deferred).*" \
> > -    "break on nonexistent function in langs.exp"
>
>
> This has an implicit "$gdb_prompt $" anchor.  All of the following
> cases need something similar; for the pending case that means you
> should replace send_gdb "n\n" with, probably, gdb_test "n" "" "break
> on...".
>
>
> > +gdb_test_multiple "break pendfunc1" "set pending breakpoint" {
> > +     -re ".*Make breakpoint pending.*$" {
>
>
> Similarly, don't do that.  As soon as expect's buffer is full, it will
> try to match, and succeed; possibly leaving a pending $gdb_prompt for
> another test to match, getting us hideously out of sync.  Match
> whatever prompt you 
>
>
>
> > +	-re "Make breakpoint pending.*y or n. $" { 
> > +		send_gdb "n\n"; 
> > +		fail "setting breakpoint at $function" ; 
> > +		return 0
> > +	}
>
>
> [in lib/gdb.exp] ditto.

Daniel, can you clarify this last comment.  Is something wrong with the prompt 
test in the -re line or do you want me to change the send_gdb to be a gdb_test?

-- Jeff J.