This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Fix some 64-bit Objective-C bugs
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Adam Fedor <fedor at doc dot com>
- Cc: Ulrich Weigand <weigand at i1 dot informatik dot uni-erlangen dot de>,gdb-patches at sources dot redhat dot com, uweigand at de dot ibm dot com
- Date: Mon, 19 Jan 2004 11:32:52 -0500
- Subject: Re: [PATCH] Fix some 64-bit Objective-C bugs
- References: <E5F2FFE55E362144876F14CB0AEE713901EB72C5@exchange1.urp.doc.com> <DE768D37-274A-11D8-A042-000A277AC1A4@doc.com>
On Fri, Dec 05, 2003 at 10:45:52AM -0700, Adam Fedor wrote:
>
> On Thursday, December 4, 2003, at 01:10 PM, Ulrich Weigand wrote:
>
> >
> >
> >ChangeLog:
> >
> >??????? * eval.c (evaluate_subexp_standard, case OP_OBJC_MSGCALL): Use
> >??????? CORE_ADDR as type for selectors.? Correct types for GNU run
> >time
> >??????? message lookup function to use double indirection.
> >??????? * objc-lang.c (lookup_child_selector): Use CORE_ADDR as return
> >type.
> >??????? * objc-lang.h (lookup_child_selector): Adapt prototype.
> >
>
> Looks good to me. It also happens to fix a problem I was just getting
> around to looking at. I'll apply it in a few days if there are no other
> comments. Thanks for taking the time to look at this.
Hi Adam,
Just reminding you that you never checked in this patch.
> >testsuite/ChangeLog:
> >
> >??????? * gdb.objc/basicclass.exp: Adapt to fixed return type of
> >printHi.
> >
> >
>
> Not sure if I have authority to approve this, unless it's under the
> obvious rule...
It's obvious. Also, I think you should be listed as the Objective-C
testsuite maintainer in addition to the Objective-C language
maintainer - does anyone disagree?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer