This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] fix trap in parallel for m32r-sim


Kazuhiro Inaoka writes:
 > Hi Andrew,
 > 
 > This is a patch for illegal trap operation in parallel. 
 > 
 > Please commit it.
 > 
 > sim/m32r/ChangeLog
 > 
 > 2004-01-16  Kazuhiro Inaoka < inaoka dot kazuhiro at renesas dot com >
 > 
 >  * mloopx.in (emit_parallel,emit_full_parallel,xextract-pbb): Fixed
 >         trap operation in parallel.
 >  * mloop2.in (emit_parallel,emit_full_parallel,xextract-pbb): Ditto.
 > 
 > Regards,
 > 
 > Kazuhiro Inaoka

There's no documentation here that indicates why things are being
done the way they are.
If it were my call, I would require more comments.
i.e. _why_ is "trap || insn" being treated as "insn -> trap".
This seems like an erroneous thing to do at first glance,
ergo the need for comments explaining why things are the way they are.
Does h/w really work that way?

Also, if things are indeed kosher, why the added FIXMEs?

Also, nit: it's unfortunate that instructions are being specified
as magic numbers, but that can be fixed later.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]