This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch/testsuite/cp] virtfunc.exp: throw out old messages, comments


This is a bit of housekeeping.  This patch removes old "(obsolescent gcc
or gdb)" and "(aCC)" decorations from gdb.cp/virtfunc.exp.  It also
removes a big comment from 2002 about the results of one test that does
not PASS.  There is already a new comment from 2004 giving the results
for that test.

I tested this on:

  native i686-pc-linux-gnu
  gcc 2.95.3, gcc 3.3.2, gcc HEAD
  dwarf-2, stabs+

I don't know what hp-ux aCC actually prints, but when I find out,
it will be easy to add cases for that.  The "(aCC)" messages were
coming out with gcc, which is embarrassing.

IACTN,

Michael C

2004-01-10  Michael Chastain  <mec.gnu@mindspring.com>

	* gdb.cp/virtfunc.exp: Remove old "(obsolescent gcc or gdb)"
	and "(aCC)" decorations.  Remove obsolete doco about old
	test results.

Index: virtfunc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/virtfunc.exp,v
retrieving revision 1.6
diff -c -3 -p -r1.6 virtfunc.exp
*** virtfunc.exp	9 Jan 2004 04:57:09 -0000	1.6
--- virtfunc.exp	11 Jan 2004 08:04:21 -0000
*************** if  { [gdb_compile "${srcdir}/${subdir}/
*** 91,169 ****
  #
  # -- chastain 2004-01-01
  
- # compatibility kludges
- set kk0 ""
- set kk1 ""
- set kk2 ""
- set kk3 ""
- set kk4 ""
- set kk5 ""
- 
- proc kk_debug { } {
-     global kk0
-     global kk1
-     global kk2
-     global kk3
-     global kk4
-     global kk5
-     set kk0 " (0)"
-     set kk1 " (1)"
-     set kk2 " (2)"
-     set kk3 " (3)"
-     set kk4 " (4)"
-     set kk5 " (5)"
- }
- 
  proc test_one_ptype { command testname re_class re_vbptr re_access_fields re_fields re_access_methods re_methods re_synth_gcc_2 re_synth_gcc_3 re_star } {
      global gdb_prompt
      global wsopt
      global ws
      global nl
  
-     global kk0
-     global kk1
-     global kk2
-     global kk3
-     global kk4
-     global kk5
- 
      gdb_test_multiple "$command" "$testname" {
  	-re "type = $re_class${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_methods$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 2.95.3, dwarf-2, no vbptr
  	    # gcc 3.X, abi 1, dwarf-2
  	    # gcc 3.X, abi 2, dwarf-2
! 	    pass "$testname$kk0"
  	}
  	-re "type = $re_class${wsopt}$re_vbptr${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_methods$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 2.95.3, dwarf-2, vbptr
  	    # TODO: drow says the vbptr is a bug
! 	    pass "$testname$kk1"
  	}
  	-re "type = $re_class${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_synth_gcc_2${wsopt}$re_methods$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 2.95.3, stabs+, no vbptr
! 	    pass "$testname$kk2"
  	}
  	-re "type = $re_class${wsopt}$re_vbptr${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_synth_gcc_2${wsopt}$re_methods$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 2.95.3, stabs+, vbptr
  	    # TODO: drow says the vbptr is a bug
! 	    pass "$testname$kk3"
  	}
  	-re "type = $re_class${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_synth_gcc_3${wsopt}$re_methods$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 3.X, abi 1, stabs+
! 	    pass "$testname$kk4"
  	}
  	-re "type = $re_class${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_methods${wsopt}$re_synth_gcc_3$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 3.X, abi 2, stabs+
! 	    pass "$testname$kk5"
  	}
      }
  
-     set kk0 ""
-     set kk1 ""
-     set kk2 ""
-     set kk3 ""
-     set kk4 ""
-     set kk5 ""
  }
  
  proc test_ptype_of_classes {} {
--- 91,133 ----
  #
  # -- chastain 2004-01-01
  
  proc test_one_ptype { command testname re_class re_vbptr re_access_fields re_fields re_access_methods re_methods re_synth_gcc_2 re_synth_gcc_3 re_star } {
      global gdb_prompt
      global wsopt
      global ws
      global nl
  
      gdb_test_multiple "$command" "$testname" {
  	-re "type = $re_class${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_methods$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 2.95.3, dwarf-2, no vbptr
  	    # gcc 3.X, abi 1, dwarf-2
  	    # gcc 3.X, abi 2, dwarf-2
! 	    pass "$testname"
  	}
  	-re "type = $re_class${wsopt}$re_vbptr${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_methods$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 2.95.3, dwarf-2, vbptr
  	    # TODO: drow says the vbptr is a bug
! 	    pass "$testname"
  	}
  	-re "type = $re_class${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_synth_gcc_2${wsopt}$re_methods$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 2.95.3, stabs+, no vbptr
! 	    pass "$testname"
  	}
  	-re "type = $re_class${wsopt}$re_vbptr${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_synth_gcc_2${wsopt}$re_methods$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 2.95.3, stabs+, vbptr
  	    # TODO: drow says the vbptr is a bug
! 	    pass "$testname"
  	}
  	-re "type = $re_class${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_synth_gcc_3${wsopt}$re_methods$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 3.X, abi 1, stabs+
! 	    pass "$testname"
  	}
  	-re "type = $re_class${wsopt}$re_access_fields${wsopt}$re_fields${wsopt}$re_access_methods${wsopt}$re_methods${wsopt}$re_synth_gcc_3$nl\}$re_star$nl$gdb_prompt $" {
  	    # gcc 3.X, abi 2, stabs+
! 	    pass "$testname"
  	}
      }
  
  }
  
  proc test_ptype_of_classes {} {
*************** proc test_ptype_of_classes {} {
*** 171,186 ****
      global ws
      global nl
  
-     global kk0
-     global kk1
-     global kk2
-     global kk3
-     global kk4
-     global kk5
- 
      # class VA
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype VA" "ptype VA" \
  	"((struct|class) VA \{${ws}public:|struct VA \{)" \
  	"" \
--- 135,142 ----
*************** proc test_ptype_of_classes {} {
*** 192,198 ****
  
      # class VB
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype VB" "ptype VB" \
  	"((struct|class) VB \{${ws}public:|struct VB \{)" \
  	"" \
--- 148,153 ----
*************** proc test_ptype_of_classes {} {
*** 204,210 ****
  
      # class V
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype V" "ptype V" \
  	"class V : public VA, public VB \{${ws}public:" \
  	"" \
--- 159,164 ----
*************** proc test_ptype_of_classes {} {
*** 216,223 ****
  
      # class A
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype A" "ptype A" \
  	"class A : public virtual V \{(${ws}private:|)" \
  	"V \\*(_vb.1V|_vb.V);" \
--- 170,175 ----
*************** proc test_ptype_of_classes {} {
*** 229,235 ****
  
      # class B
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype B" "ptype B" \
  	"class B : public A \{(${ws}private:|)" \
  	"V \\*(_vb.1V|_vb.V);" \
--- 181,186 ----
*************** proc test_ptype_of_classes {} {
*** 241,248 ****
  
      # class C
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype C" "ptype C" \
  	"class C : public virtual V \{(${ws}private:|)" \
  	"V \\*(_vb.1V|_vb.V);" \
--- 192,197 ----
*************** proc test_ptype_of_classes {} {
*** 254,260 ****
  
      # class AD
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype AD" "ptype AD" \
  	"((struct|class) AD \{${ws}public:|struct AD \{)" \
  	"" \
--- 203,208 ----
*************** proc test_ptype_of_classes {} {
*** 266,273 ****
  
      # class D
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype D" "ptype D" \
  	"class D : public AD, public virtual V \{(${ws}private:|)" \
      	"V \\*(_vb.1V|_vb.V);" \
--- 214,219 ----
*************** proc test_ptype_of_classes {} {
*** 280,286 ****
      # class E
      # TODO: E does not show a vbptr for V.  That seems strange.
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype E" "ptype E" \
  	"class E : public B, public virtual V, public D, public C \{(${ws}private:|)" \
  	"" \
--- 226,231 ----
*************** proc test_ptype_of_classes {} {
*** 292,299 ****
  
      # An instance of D
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype dd" "ptype dd" \
  	"class D : public AD, public virtual V \{(${ws}private:|)" \
      	"V \\*(_vb.1V|_vb.V);" \
--- 237,242 ----
*************** proc test_ptype_of_classes {} {
*** 305,312 ****
  
      # An instance of D *
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype ppd" "ptype ppd" \
  	"class D : public AD, public virtual V \{(${ws}private:|)" \
      	"V \\*(_vb.1V|_vb.V);" \
--- 248,253 ----
*************** proc test_ptype_of_classes {} {
*** 319,325 ****
      # An instance of AD *
      # TODO: this should be named pADd, not pAd.
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pAd" "ptype pAd" \
  	"((struct|class) AD \{${ws}public:|struct AD \{)" \
  	"" \
--- 260,265 ----
*************** proc test_ptype_of_classes {} {
*** 331,338 ****
  
      # An instance of A
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype a" "ptype a" \
  	"class A : public virtual V \{(${ws}private:|)" \
  	"V \\*(_vb.1V|_vb.V);" \
--- 271,276 ----
*************** proc test_ptype_of_classes {} {
*** 344,350 ****
  
      # An instance of B
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype b" "ptype b" \
  	"class B : public A \{(${ws}private:|)" \
  	"V \\*(_vb.1V|_vb.V);" \
--- 282,287 ----
*************** proc test_ptype_of_classes {} {
*** 356,363 ****
  
      # An instance of C
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype c" "ptype c" \
  	"class C : public virtual V \{(${ws}private:|)" \
  	"V \\*(_vb.1V|_vb.V);" \
--- 293,298 ----
*************** proc test_ptype_of_classes {} {
*** 369,376 ****
  
      # An instance of D
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype d" "ptype d" \
  	"class D : public AD, public virtual V \{(${ws}private:|)" \
      	"V \\*(_vb.1V|_vb.V);" \
--- 304,309 ----
*************** proc test_ptype_of_classes {} {
*** 382,388 ****
  
      # An instance of E
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype e" "ptype e" \
  	"class E : public B, public virtual V, public D, public C \{(${ws}private:|)" \
  	"" \
--- 315,320 ----
*************** proc test_ptype_of_classes {} {
*** 394,400 ****
  
      # An instance of V
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype v" "ptype v" \
  	"class V : public VA, public VB \{${ws}public:" \
  	"" \
--- 326,331 ----
*************** proc test_ptype_of_classes {} {
*** 406,412 ****
  
      # An instance of VB
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype vb" "ptype vb" \
  	"((struct|class) VB \{${ws}public:|struct VB \{)" \
  	"" \
--- 337,342 ----
*************** proc test_ptype_of_classes {} {
*** 418,425 ****
  
      # An instance of A *
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pAa" "ptype pAa" \
  	"class A : public virtual V \{(${ws}private:|)" \
  	"V \\*(_vb.1V|_vb.V);" \
--- 348,353 ----
*************** proc test_ptype_of_classes {} {
*** 431,438 ****
  
      # An instance of A *
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pAe" "ptype pAe" \
  	"class A : public virtual V \{(${ws}private:|)" \
  	"V \\*(_vb.1V|_vb.V);" \
--- 359,364 ----
*************** proc test_ptype_of_classes {} {
*** 444,450 ****
  
      # An instance of B *
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pBe" "ptype pBe" \
  	"class B : public A \{(${ws}private:|)" \
  	"V \\*(_vb.1V|_vb.V);" \
--- 370,375 ----
*************** proc test_ptype_of_classes {} {
*** 456,463 ****
  
      # An instance of D *
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pDd" "ptype pDd" \
  	"class D : public AD, public virtual V \{(${ws}private:|)" \
      	"V \\*(_vb.1V|_vb.V);" \
--- 381,386 ----
*************** proc test_ptype_of_classes {} {
*** 469,476 ****
  
      # An instance of D *
  
-     set kk0 " (aCC)"
-     set kk1 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pDe" "ptype pDe" \
  	"class D : public AD, public virtual V \{(${ws}private:|)" \
      	"V \\*(_vb.1V|_vb.V);" \
--- 392,397 ----
*************** proc test_ptype_of_classes {} {
*** 482,488 ****
  
      # An instance of V *
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pVa" "ptype pVa" \
  	"class V : public VA, public VB \{${ws}public:" \
  	"" \
--- 403,408 ----
*************** proc test_ptype_of_classes {} {
*** 494,500 ****
  
      # An instance of V *
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pVv" "ptype pVv" \
  	"class V : public VA, public VB \{${ws}public:" \
  	"" \
--- 414,419 ----
*************** proc test_ptype_of_classes {} {
*** 506,512 ****
  
      # An instance of V *
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pVe" "ptype pVe" \
  	"class V : public VA, public VB \{${ws}public:" \
  	"" \
--- 425,430 ----
*************** proc test_ptype_of_classes {} {
*** 518,524 ****
  
      # An instance of V *
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pVd" "ptype pVd" \
  	"class V : public VA, public VB \{${ws}public:" \
  	"" \
--- 436,441 ----
*************** proc test_ptype_of_classes {} {
*** 530,536 ****
  
      # An instance of AD *
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pADe" "ptype pADe" \
  	"((struct|class) AD \{${ws}public:|struct AD \{)" \
  	"" \
--- 447,452 ----
*************** proc test_ptype_of_classes {} {
*** 542,548 ****
  
      # An instance of E *
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pEe" "ptype pEe" \
  	"class E : public B, public virtual V, public D, public C \{(${ws}private:|)" \
  	"" \
--- 458,463 ----
*************** proc test_ptype_of_classes {} {
*** 554,560 ****
  
      # An instance of VB *
  
-     set kk0 " (obsolescent gcc or gdb)"
      test_one_ptype "ptype pVB" "ptype pVB" \
  	"((struct|class) VB \{${ws}public:|struct VB \{)" \
  	"" \
--- 469,474 ----
*************** proc test_virtual_calls {} {
*** 588,625 ****
      gdb_test "print pDe->vvb()" "\\$\[0-9\]+ = 411"
      gdb_test "print pEe->vd()"  "\\$\[0-9\]+ = 282"
      gdb_test "print pEe->fvb()" "\\$\[0-9\]+ = 311"
- 
-     # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
-     # gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gdwarf-2.
-     #
-     # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
-     # gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gstabs+.
-     #
-     # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
-     # gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gdwarf-2.
-     #
-     # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
-     # gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gstabs+.
-     #
-     # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
-     # gdb=HEAD%2002-02-16, gcc=3.0.4-20020215, goption=-gdwarf-2.
-     #
-     # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
-     # gdb=HEAD%2002-02-16, gcc=3.0.4-20020215, goption=-gstabs+.
-     #
-     # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
-     # gdb=HEAD%2002-02-16, gcc=gcc-3_0-branch%2002-02-16, goption=-gdwarf-2.
-     #
-     # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
-     # gdb=HEAD%2002-02-16, gcc=gcc-3_0-branch%2002-02-16, goption=-gstabs+.
-     #
-     # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
-     # gdb=HEAD%2002-02-16, gcc=HEAD%2002-02-16, goption=-gdwarf-2.
-     #
-     # fails on target=native, host=i686-pc-linux-gnu%rh-7.2,
-     # gdb=HEAD%2002-02-16, gcc=HEAD%2002-02-16, goption=-gstabs+.
-     #
-     # -- chastain 2002-02-20
  
      # more recent results:
      # wrong value "202"
--- 502,507 ----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]