This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] New port m32r-linux target.


Hi Nick,

>   * What is the purpose of the USE_M32R_OLD_RELOC define ?  It
>     appears to be tested at several places in the code, but it is
>     never set anywhere.
I'm sorry, the USE_M32R_OLD_RELOC used to check OLD ABI relocations.
In the future it will not be nedded.

>   * The patch introduces 6 new failures in the GAS testsuite,
>     (m32r/allinsn, m32r/high-1, m32r/relax-1, m32r/uppercase,
>     m32r/m32rx and vtable/entry0).  These must be fixed.
Yes,  I attached the fixed pattern files and new test case.

>   * It should update guess_is_rela() in binutils/readelf.c to default
>     to RELA type relocations for the M32R.
Yes, I attached the patch.

>
>   * The gas/NEWS and ld/NEWS files should be updated to mention the
>     support for the new m32r-linux target.
Yes, I attached the patch.

>   * The patch appears to introduce little-endian versions of the m32r
>     target vectors, but you did not mention this in your covering
>     email.  Is this new feature intentional ?  If so, it ought to be
>     explicitly covered in the relevant ChangeLog entries and also
>     mentioned in the NEWS files as well.
Now little-endian version is not fixed, and we can't enough take care of it.
So I'd like to commit config-files to be able to build.

Thanks!
Kazuhiro Inaoka
http://sources.redhat.com/ml/binutils/2003-12/msg00310.html

gas/ChangeLog

2003-12-19  Kazuhiro Inaoka < inaoka dot kazuhiro at renesas dot com >

        * doc/c-m32r.texi: Document -KPIC option.
        * NEWS: Support m32r Linux and PIC.

gas/testsuite/ChangeLog

2003-12-19  Kazuhiro Inaoka < inaoka dot kazuhiro at renesas dot com >

        * gas/m32r/m32rx.s: Changed pattern bncl to bncl.s.
        * gas/m32r/allinsn.d: Update for New RELA-ABI.
        * gas/m32r/high-1.d: Likewise.
        * gas/m32r/relax-1.d: Likewise.
        * gas/m32r/uppercase.d: Likewise.
        * gas/m32r/m32rx.d: Likewise.
        * gas/m32r/pic.exp: New file for PIC.
        * gas/m32r/pic.s: Likewise.
        * gas/m32r/pic.d: Likewise.

binutils/ChangeLog

2003-12-19  Kazuhiro Inaoka < inaoka dot kazuhiro at renesas dot com >

        * readelf.c (guess_is_rela): Changed m32r's default type to RELA.

ld/ChangeLog

2003-12-19  Kazuhiro Inaoka < inaoka dot kazuhiro at renesas dot com >

        * NEWS: Support m32r Linux.

Attachment: news-ld.patch
Description: Binary data

Attachment: news-as.patch
Description: Binary data

Attachment: doc.patch
Description: Binary data

Attachment: readelf.patch
Description: Binary data

Attachment: test.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]