This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Partial de-depricatification of sh64-tdep.c
Michael Snyder writes:
> Elena Zannoni wrote:
> > Michael Snyder writes:
> > > This patch gets rid of at least three deprecated functions or macros.
> > > I've tested it as well as I can, given that the current sh64 sim
> > > doesn't build. This compiles without warnings, and it tests out OK
> > > on an older branch that I have in which the sim does build.
> >
> > please split the indent/formatting changes into a separate patch.
> > It's hard to review this.
>
> Sorry, you're right. Here's the part that isn't comment/whitespace.
> I also added a couple lines of ChangeLog that I missed the first time.
>
>
>
> 2003-11-12 Michael Snyder <msnyder@redhat.com>
>
> * sh64-tdep.c:
> (sh_sh64_register_raw_size): Delete.
> (sh_sh64_register_virtual_size): Delete.
> (sh64_extract_return_value): Replace deprecated_store_floating
> with store_typed_floating.
> (sh_sh64_register_convert_to_raw): Replace
> deprecated_store_floating with store_typed_floating.
> (sh_sh64_register_virtual_type): Convert to sh64_register_type.
> (sh64_frame_chain, sh64_get_saved_pr, sh64_get_saved_register,
> sh64_nofp_frame_init_saved_regs, sh64_push_arguments,
> sh64_extract_struct_value_address, sh64_pop_frame,
> sh64_extract_return_value, sh64_store_return_value,
> sh_sh64_register_convert_to_virtual, sh64_pseudo_register_read,
> sh_sh64_register_convert_to_raw, sh_pseudo_register_write):
> Replace DEPRECATED_REGISTER_RAW_SIZE with register_size.
> Replace DEPRECATED_REGISTER_VIRTUAL_TYPE with register_type.
> (sh64_gdbarch_init): Don't set deprecated_register_bytes,
> deprecated_register_virtual_type, deprecated_register_raw_size,
> deprecated_max_register_raw_size, or
> deprecated_max_register_virtual_size. Instead, just set
> gdbarch_register_type.
>
looks good. Please apply the indentation changes (if you are running
through gdb_indent.sh) separately.
elena