This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa:symtab] deprecate inside_entry_func
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: Fri, 31 Oct 2003 17:36:54 -0700
- Subject: Re: [rfa:symtab] deprecate inside_entry_func
- References: <3FA2F940.5040102@redhat.com>
On Oct 31, 7:07pm, Andrew Cagney wrote:
> This patch deprecates the function inside_entry_func. Per the new comments:
>
> + /* NOTE: cagney/2003-10-31: A very simple test, such as
> + get_frame_func == entry_point should be sufficient for
> + identifying a pc in the entry function. Does anyone know why it
> + wasn't sufficient and hence, why the very convoluted
> + "deprecated_inside_entry_func" is needed. */
> + /* NOTE: cagney/2003-10-31: An ABI and its crt0 code should define
> + and implement a clean frame termination. Not doing that is
> + really a bug in the ABI/crt0, and, hence, not a reason for
> + enabling the call to deprecated_inside_entry_func. */
I do agree that it'd be nice if all ABIs provided a clean way to detect
the bottom-most frame. Not all of them do however, and in such cases,
a mechanism like inside_entry_func() is necessary.
So, in short, I oppose the deprecation of this function.
> It's "evil twin", inside_entry_file, has already been deprecated.
I think that's okay.
Kevin