This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] dwarf2-frame.c: Support DW_EH_PE_textrel encoding
On Fri, Oct 03, 2003 at 12:10:34AM +0200, Mark Kettenis wrote:
> I've got a problem with re-using the variable named `got' in
> dwarf2_build_frame_info() for the ".text" section. Could you please
> rename the variable to something more generic (for example `sect') or
> introduce a new variable?
>
> I'd also appreciate it if you changed gcc into GCC in the comment
> (thats the spelling the GCC project uses, and makes the sentence start
> with a capital). You'll need to add an extra space after the . too.
>
> With those changes, this is OK.
>
> * dwarf2-frame.c (struct comp_unit): Add tbase member to store
> base for DW_EH_PE_textrel encodings.
> (read_encoded_value): Add a DW_EH_PE_textrel case.
> (dwarf2_build_frame_info): Set unit.tbase to beginning of text
> section.
Applied with the suggested changes. I've introduced a new "txt" variable
instead of reusing "got".
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.