This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH/RFA/RFC] Replecament for DEPRECATED_REG_STRUCT_HAS_ADDR
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: Mark Kettenis <kettenis at chello dot nl>
- Cc: gdb-patches at sources dot redhat dot com, ac131313 at redhat dot com, eliz at gnu dot org
- Date: Tue, 16 Sep 2003 09:40:32 -0400
- Subject: Re: [PATCH/RFA/RFC] Replecament for DEPRECATED_REG_STRUCT_HAS_ADDR
- References: <200309141313.h8EDD3um071823@elgar.kettenis.dyndns.org>
Mark Kettenis writes:
> Here is the promised patch to replace DEPRECATED_REG_STRUCT_HAS_ADDR.
> I've baptized the new method stabs_argument_has_addr since that better
> describes what it does than the old REG_STRUCT_HAS_ADDR; it's also
> used for non-register and non-struct arguments, at least on SPARC. I
> also dropped the gcc_p argument since none of the current
> implementations of DEPRECATED_REG_STRUCT_HAS_ADDR actually use it.
>
> Anyway, I moved the type checks that were done in stabsread.c into
> default_stabs_argument_has_addr. This means that
> stabs_argument_has_addr has to do all type-checks. On SPARC this is
> needed to support quad-precision floating-point arguments.
>
> Andrew, I made stabs_argument_has_addr a multi-arch function, and I
> don't provide a macro for it. Is that all-right? I'm a bit confused
> when to provide a macro and when not. What are your current ideas
> about that? Personally I think we should get rid of the macros and
> explicitly use current_gdbarch.
>
> Eli, are the doc bits OK?
>
> Mark
stabs files changes are ok with me.
elena
>
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * gdbarch.sh (DEPRECATED_REG_STRUCT_HAS_ADDR): Add comment.
> (stabs_argument_has_addr): New architecture method.
> * arch-utils.h (default_stabs_argument_has_addr): New prototype.
> * arch-utils.c: Include "buildsym.h".
> (default_stabs_argument_has_addr): New function.
> * stabsread.c (define_symbol): Use stabs_argument_has_addr
> instead of DEPRECATED_REG_STRUCT_HAS_ADDR.
>
> Index: doc/ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * gdbint.texinfo (Target Architecture Definition): Document
> pass_argument_by_reference.
>