This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] New m32r remote target, m32rsdi
- From: "Kei Sakamoto" <sakamoto dot kei at renesas dot com>
- To: "Andrew Cagney" <ac131313 at redhat dot com>
- Cc: <gdb-patches at sources dot redhat dot com>
- Date: Mon, 8 Sep 2003 15:15:23 +0900
- Subject: Re: [patch] New m32r remote target, m32rsdi
- References: <02e201c35a5e$883a8cb0$5169910a@KEI> <20030817210347.GF11300@nevyn.them.org> <01af01c3679d$25650650$5169910a@KEI> <012d01c37359$e3f98510$5169910a@KEI> <3F589BD7.5080506@redhat.com>
From: "Andrew Cagney" <ac131313@redhat.com>
To: "Kei Sakamoto" <sakamoto.kei@renesas.com>
Cc: <gdb-patches@sources.redhat.com>
Sent: Friday, September 05, 2003 11:21 PM
Subject: Re: [patch] New m32r remote target, m32rsdi
> > Hello,
> >
> > I posted the following two weeks ago, but there is no reaction
> > so far.
> >
> > Its patch adds a new remote protocol to m32r architecture and
> > does not influence any other functions. So I think it's safe
> > to add.
>
> Dig dig, ah I see Daniel wrote:
>
> > I don't feel qualified to review a new remote target, so you'll have to
> > ask the remote maintainer. However, there's definitely a problem with
> > the new code. It's full of pieces like:
> >
> > if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
> > *((unsigned long *) (buf + 1)) = pc_addr;
> > else
> > *((unsigned long *) (buf + 1)) = pc_addr - 1;
> >
> > This sends host-endian data over the wire to the target. Run it on a
> > big-endian host and bad things will happen.
>
> I guess that means me (but I'm only listed for remote.c :-). I'll look
> over the revision.
Thank you for reviewing my patch!
> > I'm going to commit it next weak. Please let me know if there
> > is any problem.
>
> That wouldn't be a good idea.
I see. I'll commit it after your approval.
Kei Sakamoto