This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Improvements for sh double register display


Andrew Cagney wrote:
 > +   char *raw_buffer;
 > +   double dbl;
 > +   int inv;
 >    > !   /* Allocate space for the float. */
 > !   raw_buffer = (char *) alloca (2 * REGISTER_RAW_SIZE (FP0_REGNUM));

Can you use something other than alloca here? Also, this will collide
in mid air with Corinna's revamp. Maybe you can revisit this after she
is done? Otherwise it's ok.


Something like:

char raw_buffer[MAX_REGISTER_SIZE * 2];

will do the trick.


Wah -- didn't we just go to a bunch of trouble to get rid of those?
By "just", I suppose I mean a year or two ago...






Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]