Re: [RFA] Undeprecate sh to sh4

[Elena Zannoni <ezannoni at redhat dot com>]

Corinna Vinschen writes:
 > Hi,
 > 
 > the following patch is the first step in undeprecating the 32 bit variants
 > of the sh CPU, sh, sh2, ... to sh4.  Everything except the new frame code
 > is covered by this patch.
 > 
 > Corinna
 > 
 > 	* sh-tdep.c: Substitute calls to REGISTER_RAW_SIZE by calls to
 > 	register_size and calls to REGISTER_VIRTUAL_TYPE by calls to
 > 	gdbarch_register_type in 32 bit code throughout.  Avoid current_gdbarch
 > 	as possible.
 > 	(do_pseudo_register): Remove.
 > 	(sh_push_dummy_code): New function.
 > 	(sh64_store_struct_return): Rename from sh_store_struct_return.
 > 	Only called for sh64 now.
 > 	(sh_extract_struct_value_address): Regcache'ify.
 > 	(sh_push_dummy_call): Rename from sh_push_arguments.  Regcache'ify
 > 	and accomodate new tasks.
 > 	(sh64_push_return_address): Rename from sh_push_return_address.
 > 	Only called for sh64 now.
 > 	(sh_default_extract_return_value): Rename from sh_extract_return_value.
 > 	Regcache'ify.
 > 	(sh3e_sh4_extract_return_value): Regcache'ify.
 > 	(sh_default_store_return_value): Ditto.
 > 	(sh3e_sh4_store_return_value): Ditto.
 > 	(sh_default_register_byte): Remove.
 > 	(sh_sh4_register_byte): Remove.
 > 	(sh_default_register_raw_size): Remove.
 > 	(sh_sh4_register_raw_size): Remove.
 > 	(sh_register_virtual_size): Remove.
 > 	(sh_sh3e_register_virtual_type): Remove.
 > 	(sh_sh3e_register_type): New function.
 > 	(sh_sh4_register_virtual_type): Remove.
 > 	(sh_sh4_register_type): New function.
 > 	(sh_default_register_virtual_type): Remove.
 > 	(sh_default_register_type): New function.
 > 	(do_fv_register_info): Add parameters to accomodate call from
 > 	sh_print_registers_info.
 > 	(do_dr_register_info): Ditto.
 > 	(sh_print_pseudo_register): Rename from sh_do_pseudo_register.
 > 	Add parameters to accomodate call from sh_print_registers_info.
 > 	(sh_do_fp_register): Ditto.
 > 	(sh64_do_pseudo_register): Call do_dr_register_info,
 > 	do_fv_register_info and sh_do_fp_register with default parameters.
 > 	(sh_do_register): Add parameters to accomodate call from
 > 	sh_print_registers_info.
 > 	(sh_print_register): Ditto.
 > 	(sh_print_registers_info): Rename from sh_do_registers_info.
 > 	Add parameters to be used as gdbarch_print_registers_info
 > 	implementation.  Accomodate removed do_pseudo_register function
 > 	pointer.
 > 	(sh_compact_do_registers_info): Accomodate removed do_pseudo_register
 > 	function pointer. Call sh_print_register with default parameters.
 > 	(sh64_do_registers_info): Call sh_print_registers_info instead of
 > 	sh_do_registers_info.
 > 	(sh_gdbarch_init): Rearrange to cleanup and to allow easier
 > 	detection of deprecated vs. non-deprecated functionality.
 > 	Rename sh_call_dummy_words to sh64_call_dummy_words.  Remove
 > 	function pointer assignments by direct function calls.


OK.

elena