This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa] partial fix for PR gdb/1245

case ')': 
+	  if (permissive)
+	    {
+	      return index;
+	    }


Please drop the useless pair of braces.

BTW, there are advantages and disasvantages to constantly adding and deleting extra brances. If they are included, follow-on diffs such as:

	if (permissive)
	  {
+	    process_index (&index);
	    return index;
	  }

read much easier :-)

It'ss a gnu coding standard loose loose situtation :-)

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]