This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[obish] More -Wmissing-prototypes warnings
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sat, 14 Jun 2003 20:30:14 -0400
- Subject: [obish] More -Wmissing-prototypes warnings
This gets rid of a few more -Wmissing-prototypes. A big chunk of the
i387-tdep.c file turns out to be dead.
committed,
Andrew
2003-06-14 Andrew Cagney <cagney@redhat.com>
* mips-tdep.c (mips_register_to_value): Make static.
(mips_value_to_register): Make static.
* i386-tdep.c (i386_fetch_pointer_argument): Make static.
* ia64-tdep.c (ia64_register_raw_size): Make static.
(ia64_register_virtual_size): Make static.
(ia64_register_byte): Make static.
* i387-tdep.c: Include "i387-tdep.h".
(print_387_control_word): Delete function.
(print_387_status_word): Delete function.
(print_387_status_bits): Delete function.
(print_387_control_bits): Delete function.
* Makefile.in (i387-tdep.o): Update dependencies.
* rdi-share/host.h (Fail): Declare.
* remote-rdi.c (Fail): Update to match declaration.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.405
diff -u -r1.405 Makefile.in
--- Makefile.in 14 Jun 2003 23:43:15 -0000 1.405
+++ Makefile.in 15 Jun 2003 00:22:02 -0000
@@ -1851,7 +1851,8 @@
$(i386_tdep_h) $(i387_tdep_h) $(gregset_h)
i387-tdep.o: i387-tdep.c $(defs_h) $(frame_h) $(inferior_h) $(language_h) \
$(value_h) $(gdbcore_h) $(floatformat_h) $(regcache_h) \
- $(gdb_assert_h) $(gdb_string_h) $(doublest_h) $(i386_tdep_h)
+ $(gdb_assert_h) $(gdb_string_h) $(doublest_h) $(i386_tdep_h) \
+ $(i387_tdep_h)
ia64-aix-nat.o: ia64-aix-nat.c $(defs_h) $(inferior_h) $(target_h) \
$(gdbcore_h) $(regcache_h) $(symtab_h) $(bfd_h) $(symfile_h) \
$(objfiles_h) $(gdb_stat_h)
Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.155
diff -u -r1.155 i386-tdep.c
--- i386-tdep.c 14 Jun 2003 22:35:25 -0000 1.155
+++ i386-tdep.c 15 Jun 2003 00:22:06 -0000
@@ -1695,7 +1695,7 @@
/* Get the ith function argument for the current function. */
-CORE_ADDR
+static CORE_ADDR
i386_fetch_pointer_argument (struct frame_info *frame, int argi,
struct type *type)
{
Index: i387-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i387-tdep.c,v
retrieving revision 1.30
diff -u -r1.30 i387-tdep.c
--- i387-tdep.c 4 May 2003 10:27:47 -0000 1.30
+++ i387-tdep.c 15 Jun 2003 00:22:07 -0000
@@ -33,112 +33,8 @@
#include "doublest.h"
#include "i386-tdep.h"
+#include "i387-tdep.h"
-
-/* FIXME: The functions on this page are used by the old `info float'
- implementations that a few of the i386 targets provide. These
- functions should be removed if all of these have been converted to
- use the generic implementation based on the new register file
- layout. */
-
-static void print_387_control_bits (unsigned int control);
-static void print_387_status_bits (unsigned int status);
-
-static void
-print_387_control_bits (unsigned int control)
-{
- switch ((control >> 8) & 3)
- {
- case 0:
- puts_unfiltered (" 24 bit; ");
- break;
- case 1:
- puts_unfiltered (" (bad); ");
- break;
- case 2:
- puts_unfiltered (" 53 bit; ");
- break;
- case 3:
- puts_unfiltered (" 64 bit; ");
- break;
- }
- switch ((control >> 10) & 3)
- {
- case 0:
- puts_unfiltered ("NEAR; ");
- break;
- case 1:
- puts_unfiltered ("DOWN; ");
- break;
- case 2:
- puts_unfiltered ("UP; ");
- break;
- case 3:
- puts_unfiltered ("CHOP; ");
- break;
- }
- if (control & 0x3f)
- {
- puts_unfiltered ("mask");
- if (control & 0x0001)
- puts_unfiltered (" INVAL");
- if (control & 0x0002)
- puts_unfiltered (" DENOR");
- if (control & 0x0004)
- puts_unfiltered (" DIVZ");
- if (control & 0x0008)
- puts_unfiltered (" OVERF");
- if (control & 0x0010)
- puts_unfiltered (" UNDER");
- if (control & 0x0020)
- puts_unfiltered (" LOS");
- puts_unfiltered (";");
- }
-
- if (control & 0xe080)
- warning ("\nreserved bits on: %s",
- local_hex_string (control & 0xe080));
-}
-
-void
-print_387_control_word (unsigned int control)
-{
- printf_filtered ("control %s:", local_hex_string(control & 0xffff));
- print_387_control_bits (control);
- puts_unfiltered ("\n");
-}
-
-static void
-print_387_status_bits (unsigned int status)
-{
- printf_unfiltered (" flags %d%d%d%d; ",
- (status & 0x4000) != 0,
- (status & 0x0400) != 0,
- (status & 0x0200) != 0,
- (status & 0x0100) != 0);
- printf_unfiltered ("top %d; ", (status >> 11) & 7);
- if (status & 0xff)
- {
- puts_unfiltered ("excep");
- if (status & 0x0001) puts_unfiltered (" INVAL");
- if (status & 0x0002) puts_unfiltered (" DENOR");
- if (status & 0x0004) puts_unfiltered (" DIVZ");
- if (status & 0x0008) puts_unfiltered (" OVERF");
- if (status & 0x0010) puts_unfiltered (" UNDER");
- if (status & 0x0020) puts_unfiltered (" LOS");
- if (status & 0x0040) puts_unfiltered (" STACK");
- }
-}
-
-void
-print_387_status_word (unsigned int status)
-{
- printf_filtered ("status %s:", local_hex_string (status & 0xffff));
- print_387_status_bits (status);
- puts_unfiltered ("\n");
-}
-
-
/* Implement the `info float' layout based on the register definitions
in `tm-i386.h'. */
Index: ia64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ia64-tdep.c,v
retrieving revision 1.87
diff -u -r1.87 ia64-tdep.c
--- ia64-tdep.c 13 Jun 2003 04:40:32 -0000 1.87
+++ ia64-tdep.c 15 Jun 2003 00:22:08 -0000
@@ -235,13 +235,13 @@
return ia64_register_names[reg];
}
-int
+static int
ia64_register_raw_size (int reg)
{
return (IA64_FR0_REGNUM <= reg && reg <= IA64_FR127_REGNUM) ? 16 : 8;
}
-int
+static int
ia64_register_virtual_size (int reg)
{
return (IA64_FR0_REGNUM <= reg && reg <= IA64_FR127_REGNUM) ? 16 : 8;
@@ -297,7 +297,7 @@
return builtin_type_long;
}
-int
+static int
ia64_register_byte (int reg)
{
return (8 * reg) +
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.215
diff -u -r1.215 mips-tdep.c
--- mips-tdep.c 14 Jun 2003 22:35:25 -0000 1.215
+++ mips-tdep.c 15 Jun 2003 00:22:18 -0000
@@ -644,7 +644,7 @@
&& TYPE_LENGTH(type) == 8);
}
-void
+static void
mips_register_to_value (struct frame_info *frame, int regnum,
struct type *type, void *to)
{
@@ -652,7 +652,7 @@
frame_read_register (frame, regnum + 1, (char *) to + 0);
}
-void
+static void
mips_value_to_register (struct frame_info *frame, int regnum,
struct type *type, const void *from)
{
Index: remote-rdi.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-rdi.c,v
retrieving revision 1.26
diff -u -r1.26 remote-rdi.c
--- remote-rdi.c 11 Jun 2003 13:16:28 -0000 1.26
+++ remote-rdi.c 15 Jun 2003 00:22:19 -0000
@@ -1065,8 +1065,8 @@
/* A little dummy to make linking with the library succeed. */
-int
-Fail (void)
+void
+Fail (const char *ignored)
{
- return 0;
+
}
Index: config/i386/tm-i386.h
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/tm-i386.h,v
retrieving revision 1.45
diff -u -r1.45 tm-i386.h
--- config/i386/tm-i386.h 15 Aug 2002 19:00:47 -0000 1.45
+++ config/i386/tm-i386.h 15 Jun 2003 00:22:19 -0000
@@ -24,8 +24,4 @@
#define GDB_MULTI_ARCH GDB_MULTI_ARCH_PARTIAL
-/* FIXME: kettenis/2000-06-12: These do not belong here. */
-extern void print_387_control_word (unsigned int);
-extern void print_387_status_word (unsigned int);
-
#endif /* ifndef TM_I386_H */
Index: rdi-share/host.h
===================================================================
RCS file: /cvs/src/src/gdb/rdi-share/host.h,v
retrieving revision 1.6
diff -u -r1.6 host.h
--- rdi-share/host.h 8 Jun 2002 20:34:41 -0000 1.6
+++ rdi-share/host.h 15 Jun 2003 00:22:19 -0000
@@ -214,4 +214,7 @@
#endif
+/* Needs to be supplied by the host. */
+extern void Fail (const char *);
+
/* end of host.h */